best player map

[malyczolg]

hello , why first_player_name is not defined

		callback_playerconnect()
{
.....
    self thread checkstatus();
} 
	

		checkstatus()
{
    level.brakdanych = &"^1BRAK DANYCH";

    players = getentarray("player", "classname");
    highexp = undefined;
    name = undefined;
    highrank = undefined;
    

    for(i = 0; i < players.size; i++)
    {
        player = players[i];

        if(isdefined(player.pers["team"]) && player.pers["team"] == "spectator")
            continue;

        if(!isdefined(highexp))
        {
            highexp = player.sexp;
            name = player.name;
            highrank = player.poziom;
            continue;
        }
        
        
        wait 0.01;
        
        if(isDefined(name))
            first_player_name = name;
        else
            first_player_name = level.brakdanych;
            
        if(isDefined(highexp))
            first_player_exp = highexp;
        else
            first_player_exp = level.brakdanych;
            
        if(isDefined(highrank))
            first_player_rank = highrank;
        else
            first_player_rank = level.brakdanych;
        
        wait 3;
            
        players[i] iprintlnbold("name is" + name +"fp name is" + first_player_name);

        if(isdefined(first_player_name))
            players[i] setClientCvar("first_player", "First Player: Name:" + first_player_name + "His Exp IS:" + first_player_exp + "His rank IS:" + first_player_rank);
         else
            players[i] setClientCvar("first_player", "First Player: Name:" + "BRAK DANYCH" + "His Exp IS:" +"BRAK DANYCH" + "His rank IS:" + "BRAK DANYCH");
        
    }    
} 
	

[IzNoGoD]

Dude,
We are NOT your personal helpdesk. Please consider narrowing down the problem yourself, use some iprintlns, use some common sense.

If you need the community for every little script you are writing, you are better off not writing the scripts. It will not teach you anything if others do it for you.

I see no effort in your post to debug ANYTHING AT ALL. I dont see error logs, I dont see additional iprintlns, nothing.

The only thing we have to go on here is you saying "why is variable X not defined", while only providing a script WITHOUT any comments in it, without telling us the purpose of this script, nothing.

Please consider doing some of the stuff the community does yourself. Most of us have got the cod scripting as a hobby, we do not have a job supporting you. Providing us with insufficient data over and over again will upset us, and lead to posts like this.

Good day sir.

[Peterlankton]

If you need the community for every little script you are writing, you are better off not writing the scripts.

Couldn't have said it better myself.
I know what the script is provided to do. But seriously, the way it's scripted does not make any sense at all.
No one becomes perfect over night. I remember the good old times. I'd never debug, but I would get it working anyway. I did not know about 'developer 1', no, the only errors I got were 'Unknown Function @46436'. Sometimes just a semicolon was missing and after hours of searching I found it. So guys, I am telling you, THAT made me good at that shite. And malyczolg, you are complaining about an indefined var. Come on, you're better than that.

[Earliboy]

Well, if someone posts a problem and allready tried to find the problem by himself, then its fine for me.
But if someone comes ALWAYS if he gets an error WITHOUT trying to fix by himself, i won't help.
Specialy without sending any errors or explains. I'm NOT going to edit my mod to insert an script. It takes much time and all I will get is the same error he got.

[megazor]

I can see at least two mistakes.

		 wait 0.01;
        
        if(isDefined(name))
            first_player_name = name;
        else
            first_player_name = level.brakdanych; 
	

Firstly, wait 0.01 will be rounded upwards to 0.05 unless you have sv_fps set to 100.
Secondly, in CoD2 you have to define all variables outside if statements.

And you should really try some debugging

[IzNoGoD]

Secondly, in CoD2 you have to define all variables outside if statements.

Not true.

		if(a == b)
     c = 1;
else
     c = 2;
iprintln(c); 
	

will not produce errors

but

		if(a == b)
     c = 1;
else if(a != b)
     c = 2;
iprintln(c); 
	

will produce errors, for the script cannot be sure that it is actually called, although you can see it will.

also,

		somerandomcode();
return;
morerandomcode(); 
	

will give the "unreachable code" error.

		somerandomcode();
if(true)
     return;
morerandomcode(); 
	

will not.

CoD2 is weird.

[randall]

Write first_player_name = undefined; the first line of the function and it will work.

EDIT: Oh, and i forgot: You cannot embed localizedstrings in setClientCvar().

[malyczolg]

hi , thanks work
but if i have 100exp bot have 200exp l'm on the dvar
Who can help me?

[randall]

hi , thanks work
but if i have 100exp bot have 200exp l'm on the dvar
Who can help me?

Because your script is totally wrong. The biggest mistake is the waiting in the 'for' cycle. Try this, it causes the result you'd like to see: (not tested!)

		checkStatus()
{
    level.brakdanych = "^1BRAK DANYCH";
    first = [];
    first["player"]    = undefined;
    first["name"]    = level.brakdanych;
    first["exp"]    = level.brakdanych;
    first["rank"]    = level.brakdanych;

    players = getEntarray("player", "classname");
    for (i = 0; i < players.size; i++)
    {
        player = players[ i ];

        if (! isDefined(player.pers["team"]) || player.pers["team"] == "spectator")
            continue;

        if (! isDefined(first["player"]) || player.sexp > first["exp"])
        {
            first["player"] = player;
            first["name"] = player.name;
            first["exp"] = player.sexp;
            first["rank"] = player.poziom;
        }
    }

    for (i = 0; i < players.size; i++)
    {
        player = players[ i ];

        player setClientCvar("first_player",
                "First Player: Name:" + first["name"] +
                " His Exp IS:" + first["exp"] +
                " His rank IS:" + first["rank"]);
    }
} 
	

[malyczolg]

randall very thanks it works , can u tell me how add the second player?