custom ID ban

[Ni3ls]

Hi all,

Im working on a banfunction that bans with clientID

			case "@ban":
                if (!isdefined(self.pers["admin"]) || self.pers["admin"] < 1)
                {
                    self iprintlnbold("No admin!");
                    return;
                }
				if(isdefined(args[2]))
					id = int(args[2]);
				else
					return;
				
                if (!isdefined(args[3])) /// || args[3].size<1)
                    reden = "no reason";
                else
                {
                    //reden = "Reason: ";
                    reden = "";
                    for (i = 3; i < args.size; i++)
                        reden += args[i] + " ";
                }
				players = getentarray("player", "classname");
				for(i = 0; i < players.size; i++)
				{
						if(players[i] getEntityNumber() == id)
						{
							self thread tellmessage("PLAYER: "+players[i].name +" ID: "+players[i] getEntityNumber());
							/*id = players[i] getEntityNumber();
							ip = players[i] getIP(); 
							guid = players[i] getGUID();
							if(guid != 0)
								players[i] thread guidbanplayer(self, reden, id, guid);
							else
								players[i] thread ipbanplayer(self, reden, id, ip);*/
						}
						else
							self thread tellmessage("NO PLAYER");
				}
			    return;

When I write a non existence ID (101), like !@ban 101 REASON, it will show me the message "NO PLAYER".
When I write the correct ID, it will ban me.
However, when I write a string (aaaa) it will still kick the player with ID=0.
How to fix this?

[filthy_freak_]

		if(isdefined(args[2]) && isint(args[2]))
    id = int(args[2]);
else
    return; 
	

[Ni3ls]

		if(isdefined(args[2]) && isint(args[2]))
    id = int(args[2]);
else
    return; 
	

isint is an unknown function

[filthy_freak_]

isint is an unknown function

Oops, you need libcod and this;

		isint(char)
{
    asc = getAscii(char);
    return asc <= 57 && asc >= 48;
} 
	

[Ni3ls]

Works perfectly!

[IzNoGoD]

No, it does not.

Try kicking a player over 9, it will crash on the isint() part.

Use this instead:

		isint(string)
{
     return ((int(string) + "") == string + "");
} 
	

However this will fail to recognize -0 as a number, but that shouldnt be too big of a deal right?
}

[filthy_freak_]

That's right. isint I have is only good for using with 1 size char. Thanks for reminding me

[Ni3ls]

How does this

    asc = getAscii(char);
    return asc <= 57 && asc >= 48;

actually work?

[IzNoGoD]

10characters

[filthy_freak_]

How does this

    asc = getAscii(char);
    return asc <= 57 && asc >= 48;

actually work?

Have a look at http://www.asciitable.com/

getAscii returns the ascii number for that char.

Then it checks if that number is between 48 and 57, which are the ascii numbers for 0-9.

EDIT: Sniped.