Probelm with MySQL register.

[IzNoGoD]

Create a UNIQUE key constraint in your mysql db. Then use a stored procedure (function) to create new accounts, which use a INSERT IGNORE. Then double-check on last_insert_id inside that function. Return something if successful (possibly the user's ID), and an error code if unsuccessful (-1 should do a decent job at being an error code)

[nightbot]

Ur comment ain't helping here ..

[YuriJurek]

Killtube's being taken over by nuubz...

I had to say it xD

[nightbot]

none will help then :/

[nightbot]

@IzNoGod i managed to make the login unique and primary. But i got some problems showing errors.
If there is an account, it returns a self thread tellmessage("account exist");
but if there is no account, it doesn't process the query.
I think it's from my register case.

		case "register":
                   if(args[2].size >= 3 && args[2].size <= 20)
                   {
            haslogin = searchforlogin(args[2]);
            if(haslogin == true)
            {
                       if(args[3].size >= 5 && args[3].size <= 25)
                       {
                return;
            }
            if(haslogin == false)
            {
            iprintlnbold("ye");            
                createadmin(args[2], args[3]);
            return;
            }
            }
                self thread tellmessage("Password is too short or too long. Min 5 characters, max 25.");
                           return;
                   }
                self thread tellMessage("Login is too short or too long. Min 3 characters, max 20.");
                   return; 
	

[IzNoGoD]

Fix your indentation.

You'll see this:

		    case "register":
        if(args[2].size >= 3 && args[2].size <= 20)
        {
            haslogin = searchforlogin(args[2]);
            if(haslogin == true)
            {
                if(args[3].size >= 5 && args[3].size <= 25)
                {
                    return;
                }
                if(haslogin == false)
                {
                    iprintlnbold("ye");            
                    createadmin(args[2], args[3]);
                    return;
                }
            }
            self thread tellmessage("Password is too short or too long. Min 5 characters, max 25.");
            return;
        }
        self thread tellMessage("Login is too short or too long. Min 3 characters, max 20.");
        return; 
	

the if(haslogin == false) is inside the if(haslogin == true)

[maxdamage99]

WTF? Izno..

		if(param==true)
{
/*...*/
if(param==false)
{
/*...*/
}
/*...*/
} 
	

Try:

		case "register":
{        
    if(args[2].size >= 3 && args[2].size <= 20)
    {
        if(args[3].size >= 5 && args[3].size <= 25)
        {
            haslogin = searchforlogin(args[2]);
              if(haslogin)
                 self iprintlnbold("Login taked!");    
              else
                 if(!haslogin)
                 {
                 self iprintlnbold("Login no register!");            
                 createadmin(args[2], args[3]);
                 }
        }
        else
        self thread tellmessage("Password is too short or too long. Min 5 characters, max 25.");
    }
    else
    self thread tellMessage("Login is too short or too long. Min 3 characters, max 20.");
return;
} 
	

[IzNoGoD]

WTF? Izno..

I replied with HIS code properly indented to show that it is wrong.

[nightbot]

Thx for ur help.
Even when the user is available i get that Login taked !

This is my searchforlogin thread

		SearchForLogin(login)
{
    maps\mp\gametypes\_mysql::asyncQuery("SELECT login FROM admins WHERE login = '" + maps\mp\gametypes\_mysql::stripString(login) + "' LIMIT 1", ::checkLogin);
}

checkLogin(rows, args)
{    
   if(isDefined(rows) && isDefined(rows[0]) && isDefined(rows[0]["login"]) && isDefined(self))
   {

        self tellMessage("I'm sorry, but login " + rows[0]["login"] + "^7 already exist. Choose another one.");
        return;
   }

} 
	

This is my query for creating the account:

		CreateAdmin(login, pass)
{
    maps\mp\gametypes\_mysql::asyncQuery("INSERT INTO admins (login, pass) VALUES ('" + maps\mp\gametypes\_mysql::stripString(login) + "', '" + maps\mp\gametypes\_mysql::stripString(pass) + "')");
    self thread tellmessage("success");
} 
	

Maybe a problem in searchforlogin ?

[nightbot]

IzNoGod it would be cool if you fix it :s