-
29th August 2013, 15:44
#4
Assadministrator
Lets dissect this script.
Code:
randomize = (0, 0, 0);
Nuff said.
Code:
target1 = self.plane;
self.plane is undefined at this point, making target1 undefined. This variable is not used anywhere again.
Following that bit of code, there is code copy-pasted 5 times. Really? Loops.
Between those copy-pastes are waits. Though you reuse the original players array, which might result in some players not being connected anymore. ALWAYS refresh that stuff after a wait.
There is a stoploopsound() at the end, but there is no playloopsound() in your code.
Your script is enclosed in a for(; loop, has an endon("napalm_stop");, yet you still use both a notify and a break to stop the thread, while there is nothing to loop over. (the for(; loop can be deleted.)
Furthermore, for the other 2 functions in there the same comments apply as in your other thread.
You made some impressive-looking code, but upon closer inspection it is linearly coded, has a lot of flaws an unused variables and is one giant copy-paste party.
-
Posting Permissions
- You may not post new threads
- You may not post replies
- You may not post attachments
- You may not edit your posts
-
Forum Rules