String output for system()

[voron00]

Hi, i've changed the system() function to return a string of executed command instead of an builtin true/false. This allows to do some interesting stuff like executing external scripts in Perl/PHP etc. and get an output from them.
Grab it: https://github.com/voron00/libcod/co...c667fb9868f82a
Here is a little example:
A geolocation script written in Perl

		# List of modules
use strict;                     # strict keeps us from making stupid typos
use warnings;                   # helps us find problems in code
use diagnostics;                # good for detailed explanations about any problems in code
use Geo::IP;                    # GeoIP is used for locating IP addresses

my $ip = $ARGV[0];

if (!$ip) { die("No IP-Address has been defined"); }

if ($ip =~ /^192\.168\.|^10\.|^169\.254\./) { die("Local Network"); }

if ($ip !~ /^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/) {
    die("Invalid IP-Address: $ip");
}
    
my $gi = Geo::IP->open("Geo/GeoLiteCity.dat", GEOIP_STANDARD);
my $record = $gi->record_by_addr($ip);
my $geo_ip_info;
if (!$record) { die("No location found for this IP-Address"); }

    if ($record->city) {

        # we know the city
        if ($record->region_name) {

            # and we know the region name
            if ($record->city ne $record->region_name) {

                # the city and region name are different, all three are relevant.
                $geo_ip_info = $record->city . '^7,^2 ' . $record->region_name . ' ^7-^2 ' . $record->country_name;
            }
            else {
                # the city and region name are the same.  Use city and country.
                $geo_ip_info = $record->city . '^7,^2 ' . $record->country_name;
            }
        }
        else {
            # Only two pieces we have are city and country.
            $geo_ip_info = $record->city . '^7,^2 ' . $record->country_name;
        }
    }
    elsif ($record->region_name) {

        # don't know the city, but we know the region name and country.  close enough.
        $geo_ip_info = $record->region_name . '^7,^2 ' . $record->country_name;
    }
    elsif ($record->country_name) {

        # We may not know much, but we know the country.
        $geo_ip_info = $record->country_name;
    }
    elsif ($record->country_code3) {

        # How about a 3 letter country code?
        $geo_ip_info = $record->country_code3;
    }
    elsif ($record->country_code) {

        # How about a 2 letter country code at least?
        $geo_ip_info = $record->country_code;
    }
    else {
        # I give up.
        $geo_ip_info = "Unknown location";
    }

print "$geo_ip_info\n"; 
	

Which i cruly copypasted from Nanny, this would return city (in some case not), region name, and country.
So in gsc i would run it like

		location = system("perl locate.pl " + self getIP()); 
	

and then iprintln the result:

Ye that's right.

[voron00]

Well shit, When running a more complicated code which output would be delayed, this would lag the server since it waits for that output, would need a thread or something...

[kung foo man]

inb4 async nodejs for libcod, or like izno did with async mysql

nice job and nice too see some ppl come up with something

[maxdamage99]

V KAKUYU DIRECTORIYU KIDAT' PERL SCRIPT??
p.s: ili perl iz lyboy "hvataet"??!

[voron00]

V KAKUYU DIRECTORIYU KIDAT' PERL SCRIPT??
p.s: ili perl iz lyboy "hvataet"??!

You can run scripts from any directory by cd'ing && executing, but GeoIP database lookup takes too much time, it would lag the server as i said before.

Anyway, i tried to mess around the pthreads but there seems to be no way to push the value from a thread function into the gsc. Well, i reverted the original system() but added mine as execute():
https://github.com/voron00/libcod/co...659bd93d081db8
Proably gonna leave it like that, seems fine by me.

[maxdamage99]

вери бед инглиш ворон...
p.s:
if you got error:

Can't locate Geo/IP.pm in @INC (you may need to install the Geo::IP module) (@INC contains: /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at locate.pl line 5.
BEGIN failed--compilation aborted at locate.pl line 5 (#1)
    (F) You said to do (or require, or use) a file that couldn't be found.
    Perl looks for the file in all the locations mentioned in @INC, unless
    the file name included the full path to the file.  Perhaps you need
    to set the PERL5LIB or PERL5OPT environment variable to say where the
    extra library is, or maybe the script needs to add the library name
    to @INC.  Or maybe you just misspelled the name of the file.  See
    "require" in perlfunc and lib.

Uncaught exception from user code:
        Can't locate Geo/IP.pm in @INC (you may need to install the Geo::IP module) (@INC contains: /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at locate.pl line 5.
        BEGIN failed--compilation aborted at locate.pl line 5.

put in terminal:

perl -MCPAN -e "install Geo::IP::PurePerl" 
perl -MCPAN -e "install Geo::IP"

or look: http://kb.odin.com/en/120247
http://dev.maxmind.com/geoip/legacy/install/city/

[maxdamage99]

Data based:
https://dropmefiles.com/loZGb

[IzNoGoD]

You forgot to free() the result you get from your function. Might cause out of memory errors if you use the function a lot.

[maxdamage99]

How izno??

[IzNoGoD]

How izno??

this is for voron