name , client id in menu

Yeah, it's the script. This works:

PHP Code:

---

Callback_PlayerConnect()
{
    thread dummy();

    self.statusicon = "hud_status_connecting";
    self waittill( "begin" );
    self.statusicon = "";

    level notify( "connected", self );

    i = self getEntityNumber();
    
    self setClientCvar( "player_" + i, self.name );  
    self iprintlnbold( "player_" + i );
    self iprintlnbold( self.name );

    lpselfnum = self getEntityNumber();
    lpGuid = self getGuid();
    logPrint("J;" + lpGuid + ";" + lpselfnum + ";" + self.name + "\n");

    if( game["state"] == "intermission" )
    {
        spawnIntermission();
        return;
    }
----------- snip ---------------- 


---

That wont give your name as clientcvar to all clients, only to yourself

Quote:

---

Originally Posted by IzNoGoD

That wont give your name as clientcvar to all clients, only to yourself

---

So does the other method - it only sets the cvar on a player if their entity number matches their trace in the for() loop. So, that means only to themselves. Not to everyone.

EDIT -

If it is truly wanted, this sets the Cvar for all players:

PHP Code:

---

Callback_PlayerConnect()
{
    thread dummy();

    self.statusicon = "hud_status_connecting";
    self waittill( "begin" );
    self.statusicon = "";

    level notify( "connected", self );

    i = self getEntityNumber();
    
    setCvar( "player_" + i, self.name );  

    self iprintlnbold( "player_" + i );
    self iprintlnbold( self.name );

    lpselfnum = self getEntityNumber();
    lpGuid = self getGuid();
    logPrint("J;" + lpGuid + ";" + lpselfnum + ";" + self.name + "\n");

    if( game["state"] == "intermission" )
    {
        spawnIntermission();
        return;
    }

----------- snip ---------------- 


---

setCvar() will only set a server cvar, not a cvar for all players. Without setting them for every client using setClientCvar(), the names won't show up in the menu.

Quote:

---

Originally Posted by Peterlankton

setCvar() will only set a server cvar, not a cvar for all players. Without setting them for every client using setClientCvar(), the names won't show up in the menu.

---

If you mean a player wont see the value of cvar in a menu unless it is set on them as well, I know that. But I was shot down for not setting the cvar for all, so I added the edit as a bit of a joke. I don't believe Niels' original code intended to set the cvar on all players because it limits that action to whichever player has the same entity number as the loop increment. I thought this was backed up by the fact that, if you are going to use onPlayerConnect, you don't try to set a cvar on all players from there. It isn't the place to do it. You do it from some other place.

Going on the yet unfounded assumption that Niels wanted to set the cvar on all players, if I were doing this, I would probably do something like this:

PHP Code:

---

Callback_PlayerConnect()
{
    thread dummy();

    self.statusicon = "hud_status_connecting";
    self waittill( "begin" );
    self.statusicon = "";

    level notify( "connected", self );

    i = self getEntityNumber();
    dvar = "player_" + i;
    self setClientCvar( dvar, self.name ); 
    self thread UpdateAllPLayers( dvar, self, self.name );

    self iprintlnbold( "player_" + i );
    self iprintlnbold( self.name );

    lpselfnum = self getEntityNumber();
    lpGuid = self getGuid();
    logPrint("J;" + lpGuid + ";" + lpselfnum + ";" + self.name + "\n");

    if( game["state"] == "intermission" )
    {
        spawnIntermission();
        return;
    }

----------- snip ---------------- 

}

UpdateAllPLayers( dvar, newPlayer, name )
{

    players = getEntArray( "player", "classname" );
    for( i=0; i < players.size; i++ )
    {
        players = players[i];
        if( players == NewPlayer )
            continue;

        players setClientCvar( dvar, name );
    }

} 


---

That works because I tested it. Which was the whole point to begin with - Niels' original code did not work because it was trying to set a cvar on players from onPlayerConnect and using a loop trace to find 1 player when the player was already defined. I thought that was pretty redundant, so I posted the easier way of doing that. People then interjected that it wasn't setting the dvar on all players, and that's where the whole thing got side-tracked.

People really need to start taking notice of the POINT of a thread. Not nit picking at the smallest detail. Really does begin to get on your tits after a while.

Works perfectly!

Try to make one player disconnect. It will not empty the string.
Try to change your name. It will not change with you.

Fixed it.Everytime i open the menu I update the cvars

Oh no, doesnt work. It works for the name check, but when u disconnect it stilll appears in the list :(

Quote:

---

Originally Posted by Ni3ls

Oh no, doesnt work. It works for the name check, but when u disconnect it stilll appears in the list :(

---

Create a method at Callback_PlayerDisconnect(). When the player leaves, update all players:

PHP Code:

---

Callback_PlayerDisconnect()
{
    self dropFlag();

    if(!level.splitscreen)
        iprintln(&"MP_DISCONNECTED", self);

    dvar = "player_" + getEntityNumber();
    self thread UpdateAllPLayersDisconnect( dvar );

    if(isdefined(self.pers["team"]))
    {
        if(self.pers["team"] == "allies")
            setplayerteamrank(self, 0, 0);
        else if(self.pers["team"] == "axis")
            setplayerteamrank(self, 1, 0);
        else if(self.pers["team"] == "spectator")
            setplayerteamrank(self, 2, 0);
    }

    lpselfnum = self getEntityNumber();
    lpGuid = self getGuid();
    logPrint("Q;" + lpGuid + ";" + lpselfnum + ";" + self.name + "\n");
}

UpdateAllPLayersDisconnect( dvar )
{
    players = getEntArray( "player", "classname" );
    for( i=0; i < players.size; i++ )
    {
        players[i] setClientCvar( dvar, "" );
    }

} 


---