Ranking not work

Code:

---

init()
{
        addrank(1, 70);
        addrank(2, 720);
        addrank(3, 770);
        addrank(4, 790);
        addrank(5, 7150);
        addrank(6, 7200);
        addrank(7, 7250);
        addrank(8, 7300);
        addrank(9, 7350);
        addrank(10, 7400);
        addrank(11, 7450);
        addrank(12, 7500);
        addrank(13, 7550);
        addrank(14, 7600);
        addrank(15, 7650);
        addrank(16, 7700);
        addrank(17, 7750);
        addrank(18, 7850);
        addrank(19, 7920);
        addrank(20, 8000);
        addrank(21, 8100);
        addrank(22, 8150);
        addrank(23, 8200);
        addrank(24, 8250);
        addrank(25, 8300);
        addrank(26, 8350);
        addrank(27, 8400);
        addrank(28, 8450);
        addrank(29, 8500);
        addrank(30, 8550);
        addrank(31, 8600);
        addrank(32, 8650);
        addrank(33, 8700);
        addrank(34, 8750);
        addrank(35, 8800);
        addrank(36, 8870);
        addrank(37, 8900);
        addrank(38, 9000);
        addrank(39, 9100);
        addrank(40, 9200);
        addrank(41, 9300);
        addrank(42, 9400);
        addrank(43, 9500);
        addrank(44, 9600);
        addrank(45, 9700);
        addrank(46, 9800);
        addrank(47, 9900);
        addrank(48, 10000);
        addrank(49, 10500);
        addrank(50, 10600);
        addrank(51, 11000);
        addrank(52, 12400);
        addrank(53, 12500);
        addrank(54, 12600);
        addrank(55, 12700);
        addrank(56, 12800);
        addrank(57, 13000);
        addrank(58, 13900);
        addrank(59, 14000);
        addrank(60, 14200);
        addrank(61, 14300);
        addrank(62, 14400);
        addrank(63, 14500);
        addrank(64, 14600);
        addrank(65, 14700);
        addrank(66, 14800);
        addrank(67, 14900);
        addrank(68, 15000);
        addrank(69, 15100);
        addrank(70, 15200);
        addrank(71, 15300);
        addrank(72, 15400);
        addrank(73, 15500);
        addrank(74, 15600);
        addrank(75, 15700);
        addrank(76, 15800);
        addrank(77, 15850);
        addrank(78, 15900);
        addrank(79, 16000);
        addrank(80, 16900);
        addrank(81, 17300);
        addrank(82, 17700);
        addrank(83, 18100);
        addrank(84, 18500);
        addrank(85, 18900);
        addrank(86, 19300);
        addrank(87, 19700);
        addrank(88, 20100);
        addrank(89, 20500);
        addrank(90, 20900);
        addrank(91, 21300);
        addrank(92, 21700);
        addrank(93, 22100);
        addrank(94, 22500);
        addrank(95, 22900);
        addrank(96, 23300);
        addrank(97, 23700);
        addrank(98, 24100);
        addrank(99, 24500);
        addrank(100, 25000);
}
playerinit()
{
        self.rank = 1;
        self.prestige = 0;
}
addrank(rank, pts)
{
        level._rank[rank] = pts;
}
checkRank()
{
        rank = self.rank - self.prestige*100;
        if(!isdefined(level._rank[rank+1])) return;
       
        ranked = false;
        while(self.pts > level._rank[rank+1] && isdefined(level._rank[rank+1]))
        {
                rank++;
                self.rank++;
                ranked = true;
                self iprintlnbold("^2You have Reached Rank ^7"+self.rank);
                self iprintln("^2You have Reached Rank ^7"+self.rank);
                self thread maps\mp\gametypes\_plusscore::plusscore(1000); 
            self.scoretoshow=1000;
                self.money += 1000;
        }
        if(!ranked) return;
       
        self playlocalsound("rankup");

        if(self.rank == 100)
        {
                self iprintlnbold("^2You are Rank 100!");
                self.prestige++;
                self iprintlnbold("^2You now have " + self.prestige + " prestige^2!");
                self.pts = 0;
        }
       
        return;

               
        if (self.pts >= 0)
        {
        self.rank = 1;
        self playLocalSound("rankup");

        }

        if (self.pts >= 20)
        {
        self.rank = 2;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 70)
        {
        self.rank = 3;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 90)
        {
        self.rank = 4;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 150)
        {
        self.rank = 5;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 200)
        {
        self.rank = 6;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 400)
        {
        self.rank = 7;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 700)
        {
        self.rank = 8;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 800)
        {
        self.rank = 9;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 900)
        {
        self.rank = 10;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1000)
        {
        self.rank = 11;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1100)
        {
        self.rank = 12;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1200)
        {
        self.rank = 13;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1300)
        {
        self.rank = 14;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1400)
        {
        self.rank = 15;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1500)
        {
        self.rank = 16;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1600)
        {
        self.rank = 17;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1700)
        {
        self.rank = 18;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1800)
        {
        self.rank = 19;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 1900)
        {
        self.rank = 20;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 2000)
        {
        self.rank = 21;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 2100)
        {
        self.rank = 22;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 2200)
        {
        self.rank = 23;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 2300)
        {
        self.rank = 24;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 2400)
        {
        self.rank = 25;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 2600)
        {
        self.rank = 26;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 2800)
        {
        self.rank = 27;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 3000)
        {
        self.rank = 28;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 3200)
        {
        self.rank = 29;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 3400)
        {
        self.rank = 30;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 3600)
        {
        self.rank = 31;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 3800)
        {
        self.rank = 32;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 4000)
        {
        self.rank = 33;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 4200)
        {
        self.rank = 34;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 4400)
        {
        self.rank = 35;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 4600)
        {
        self.rank = 36;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 4800)
        {
        self.rank = 37;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 5000)
        {
        self.rank = 38;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 5200)
        {
        self.rank = 39;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 5400)
        {
        self.rank = 40;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 5600)
        {
        self.rank = 41;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 5800)
        {
        self.rank = 42;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 6000)
        {
        self.rank = 43;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 6200)
        {
        self.rank = 44;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 6400)
        {
        self.rank = 45;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 6600)
        {
        self.rank = 46;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 6800)
        {
        self.rank = 47;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 7000)
        {
        self.rank = 48;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 7200)
        {
        self.rank = 49;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 7400)
        {
        self.rank = 50;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 7700)
        {
        self.rank = 51;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 8000)
        {
        self.rank = 52;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 8300)
        {
        self.rank = 53;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 8600)
        {
        self.rank = 54;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 8900)
        {
        self.rank = 55;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 9200)
        {
        self.rank = 56;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 9500)
        {
        self.rank = 57;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 9800)
        {
        self.rank = 58;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 10100)
        {
        self.rank = 59;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 10400)
        {
        self.rank = 60;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 10700)
        {
        self.rank = 61;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 11000)
        {
        self.rank = 62;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 11300)
        {
        self.rank = 63;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }
        if (self.pts >= 11600)
        {
        self.rank = 64;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 11900)
        {
        self.rank = 65;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 12200)
        {
        self.rank = 66;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 12500)
        {
        self.rank = 67;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 12800)
        {
        self.rank = 68;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 13100)
        {
        self.rank = 69;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 13400)
        {
        self.rank = 70;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 13700)
        {
        self.rank = 71;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 14000)
        {
        self.rank = 72;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 14300)
        {
        self.rank = 73;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 14600)
        {
        self.rank = 74;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 14900)
        {
        self.rank = 75;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 15300)
        {
        self.rank = 76;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 15700)
        {
        self.rank = 77;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 16100)
        {
        self.rank = 78;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

        if (self.pts >= 16500)
        {
        self.rank = 79;
        self playLocalSound("rankup");
        self iprintlnbold("");
        }

}

---

Okey,here is ranking system,which is not adding ranks ...

Somebody know where is the problem?

This is the worst script i've ever seen.

PHP Code:

---

checkRank()
{
    rank = self.rank - self.prestige*100;
    if(!isdefined(level._rank[rank+1])) return;
    
    ranked = false;
    while(self.pts > level._rank[rank+1] && isdefined(level._rank[rank+1]))
    {
        rank++;
        self.rank++;
        ranked = true;
        self iprintlnbold("^2You have Reached Rank ^7"+self.rank);
        self iprintln("^2You have Reached Rank ^7"+self.rank);
        self thread maps\mp\gametypes\_plusscore::plusscore(1000);  
        self.scoretoshow=1000;
        self.money += 1000;
    }
    if(!ranked) return;
    
    self playlocalsound("rankup");

    if(self.rank == 100)
    {
        self iprintlnbold("^2You are Rank 100!");
        self.prestige++;
        self iprintlnbold("^2You now have " + self.prestige + " prestige^2!");
        self.pts = 0;
    }
    
    return; // DELETE THIS RANDOM RETURN, then the rest is getting executed

        
    if (self.pts >= 0)
    {
    self.rank = 1;
    self playLocalSound("rankup");

    } 


---

Just delete that return; then the code after it in checkRank() will be executed

But I guess thats not the only problem :D

This is the worst script i've ever seen.
why? :]

Oh boy
I've been waiting for such an opportunity.

1. Indentation is not correct (not really an issue, just makes the script even less readable)
2. level._rank array is not initialized (level._rank = []; )
3. You have no support for losing ranks (demotion, losing xp etc)
4. You can have multiple rank-ups in a single call of checkrank (resulting in multiple iprintlns)
5. If you actually USED DEVELOPER 1 you would see cod throws an error of "unreachable code", the 100 IF-statements found lingering around in the basement of your script (there is a return; right before them)
6. As 5. stated, no developer is used, as advised by my "WHAT TO DO BEFORE POSTING ABOUT SCRIPTING ERRORS" sticky post.
7. You reset self.pts to 0 instead of letting a person carry over their remaining points to their next prestige level
8. You hardcode a lvl 100 as max rank, while you could just as easily make it softcoded from the level._rank array
9. You dont init self.money as far as we can see
10. You are abusing my plusscore system by hardcoded setting scoretoshow to 1000, while it handles the n*1000 pretty damn well also.
11. Have you even looked at your code half-eyed? You'd see the massive appendix doing nothing at all. You did not code this yourself. (not only because of the aforementioned reasons, but also because I've seen this huge code before)

I've seen this huge code before,where you saw it? :]

Quote:

---

Originally Posted by Rocky

I've seen this huge code before,where you saw it? :]

---

He saw it now - you just posted it. He didn't need to have seen it before. One look at it tells you everything you need to know about it. I have to agree with him: it is not very elegant coding. It's a mess. Whoever did it originally was only a noob at COD script.

Quote:

---

Originally Posted by Tally

He saw it now - you just posted it. He didn't need to have seen it before. One look at it tells you everything you need to know about it. I have to agree with him: it is not very elegant coding. It's a mess. Whoever did it originally was only a noob at COD script.

---

Actually, i DID see it before.

Someone sent it to me on xfire, most likely it's a part of some zombie mod