PDA

View Full Version : script error :(



Loveboy
1st May 2013, 13:38
Hi guys, i have here a script:


vip(response)
{
switch(response)
{
case "1":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("m14_vip_mp");
}
esle
{ // <- Line 302
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "2":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("m4a1_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "3":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("ak74_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "4":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("commando_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "5":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("mp5_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "6":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("aa12_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "7":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("g36c_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;
}
}

vip2(response)
{
switch(response)
{
case "1":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("scar_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "2":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("fg42_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "3":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("rsass_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;

case "4":
if(self getGuid() == 1689738)
{
self takeWeapon(self getCurrentWeapon());
self giveWeapon("tar21_vip_mp");
}
esle
{
self iprintlnbold("You are not a VIP! You can buy VIP from Loveboy. XFIRE: 2call2fo2duty2");
}
break;
}
}


and my script error is this:


******* script compile error *******
bad syntax: (file 'maps/mp/gametypes/_quickmessages.gsc', line 302)
{
*
************************************

know somebody what is wrong?

malyczolg
1st May 2013, 13:50
http://killtube.org/showthread.php?1253-admin-panel-bashmode&highlight=admin

look Earliboy post


If you only do 1 statement in a if or else, you donīt need the {} (Same in while and for loopings). But if you use more then 1 statement the {} are needed.

delete all {,} and test

kung foo man
1st May 2013, 13:51
Replace each "esle" with "else" ^^

Loveboy
1st May 2013, 14:35
lol shit i am stupid

serthy
1st May 2013, 16:13
lol shit i am stupid

xxxxxxxxxD

btw you should shorten your script



vip( response )
{
vip = [];
vip[vip.size] = 1689738;

guid = self getGuid();
valid = false;

for( i = 0 ; i < vip.size ; i++ )
{
if( vip[i] == guid )
{
valid = true;
break;
}
}

if( !valid )
return self iPrintLnBold( "NO VIP!" );

weapon = "";

switch( response )
{
case "0" : weapon = "your_weapon_mp"; break;
case "1" : weapon = "your_weapon_mp"; break;
case "2" : weapon = "your_weapon_mp"; break;
case "3" : weapon = "your_weapon_mp"; break;
case "4" : weapon = "your_weapon_mp"; break;
case "5" : weapon = "your_weapon_mp"; break;
case "6" : weapon = "your_weapon_mp"; break;
}

if( weapon != "" )
{
self takeWeapon( self getCurrentWeapon() );
self giveWeapon( weapon );
self switchToWeapon( weapon );
}
}

IzNoGoD
1st May 2013, 17:45
xxxxxxxxxD

btw you should shorten your script



vip( response )
{
vip = [];
vip[vip.size] = 1689738;

guid = self getGuid();
valid = false;

for( i = 0 ; i < vip.size ; i++ )
{
if( vip[i] == guid )
{
valid = true;
break;
}
}

if( !valid )
return self iPrintLnBold( "NO VIP!" );

weapon = "";

switch( response )
{
case "0" : weapon = "your_weapon_mp"; break;
case "1" : weapon = "your_weapon_mp"; break;
case "2" : weapon = "your_weapon_mp"; break;
case "3" : weapon = "your_weapon_mp"; break;
case "4" : weapon = "your_weapon_mp"; break;
case "5" : weapon = "your_weapon_mp"; break;
case "6" : weapon = "your_weapon_mp"; break;
}

if( weapon != "" )
{
self takeWeapon( self getCurrentWeapon() );
self giveWeapon( weapon );
self switchToWeapon( weapon );
}
}

Please use setweaponslotweapon() instead of takeweapon(self getcurrentweapon()).
Else, when you have no weapon (on ladder or mantling), the script doesnt take any weapon.

With setweaponslotweapon you would still need to determine currentweaponslot, but that is quite easy.

Earliboy
1st May 2013, 19:58
http://killtube.org/showthread.php?1253-admin-panel-bashmode&highlight=admin

look Earliboy post


Still wrong,
i said: "you donīt need" but i dindīt said u MUST remove them.
Its just to make your script shorter and easier to read.
I personally donīt like the {} if u only use 1 statement in a if/else

@loveboy
remove the "if getGuid()" stuff.
Just do that stuff at connecting like "self getRank();"



getRank()
{
if(!thread guidCheck(self getGuid()))
return;

self.rank["vip"] = true;
self.rank["god"] = true;
//also you need to move this stuff to an switch
}

guidCheck(guid)
{
switch(guid)
{
case 1234567:
return true;
default:
return false;
}
//Since we are still here ... (blabla)
return false;
}


You can easy write a system to give ppl access to menus/vip stuff.
You donīt need to use at every line if(self getGuid == 1234 || self getGuid == 213424353) etc.
You just need then: if(self.rank["vip"]) dostuff();